feat(writer): add NULL_COUNT to vortex.stats zone-maps#124
Merged
Conversation
Extends zone-map emission with the per-zone null count (Stat ordinal 6, nullable U64), so the bitset is now MAX|MIN|NULL_COUNT (0x58) — matching what Rust fixtures carry ([MIN,MAX,NULL_COUNT]). Per-chunk null counts are captured at write time from NullableData validity (0 for dense arrays). Round-trip test covers nullable (per-zone counts 1,2) and non-nullable (all zero) columns; Rust JNI interop reads the null_count-bearing files. Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends zone-map emission with the per-zone null count (Stat ordinal 6,
nullable U64), so the bitset is now MAX|MIN|NULL_COUNT (0x58) — matching
what Rust fixtures carry ([MIN,MAX,NULL_COUNT]). Per-chunk null counts are
captured at write time from NullableData validity (0 for dense arrays).
Round-trip test covers nullable (per-zone counts 1,2) and non-nullable
(all zero) columns; Rust JNI interop reads the null_count-bearing files.
Co-Authored-By: Claude Opus 4.8 [email protected]